Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(workflowengine): Remove unused property track-by #38310

Merged
merged 2 commits into from
May 16, 2023
Merged

fix(workflowengine): Remove unused property track-by #38310

merged 2 commits into from
May 16, 2023

Conversation

nickvergessen
Copy link
Member

Checklist

@nickvergessen
fix(workflowengine): Remove unused property track-by
ae586e2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
chore(assets): Recompile JS
96a4274 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 27 milestone May 16, 2023
@nickvergessen nickvergessen self-assigned this May 16, 2023
@nickvergessen nickvergessen mentioned this pull request May 16, 2023
Merged
1 task
szaimen
szaimen approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@nickvergessen nickvergessen requested review from a team and Fenn-CS and removed request for a team May 16, 2023 13:35
@nickvergessen nickvergessen merged commit 1ce8fc6 into master May 16, 2023
@nickvergessen nickvergessen deleted the followup/38170/remove-former-track-by-property branch May 16, 2023 17:40
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug feature: workflows
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @susnux @szaimen